Callback type names should be suffixed with _cb#5102
Merged
Conversation
tiennou
approved these changes
Jun 10, 2019
Contributor
tiennou
left a comment
tiennou
left a comment
There was a problem hiding this comment.
LGTM, though a typo is involved 😉. I have a fuzzy memory that someone from Rugged had filed an issue to get us to normalize those typedefs a few months back, but couldn't find it…
| /**@{*/ | ||
|
|
||
| typedef git_cred_sign_cb git_cred_sign_callback; | ||
| typedef git_cred_ssh_interactive_cb git_cred_ssh_interactive_callback;; |
The credential callbacks should match the other callback naming conventions, using the `_cb` suffix instead of a `_callback` suffix.
The trace logging callbacks should match the other callback naming conventions, using the `_cb` suffix instead of a `_callback` suffix.
ethomson
force-pushed
the
ethomson/callback_names
branch
from
6da29f0 to
178df69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credential and trace callbacks should match the other callback naming conventions, using the
_cbsuffix instead of a_callbacksuffix.