Skip to content

Define SYMBOLIC_LINK_FLAG_DIRECTORY if required#5077

Merged
ethomson merged 1 commit into
libgit2:masterfrom
jacquesg:symbolic_link_flag_directory
May 20, 2019
Merged

Define SYMBOLIC_LINK_FLAG_DIRECTORY if required#5077
ethomson merged 1 commit into
libgit2:masterfrom
jacquesg:symbolic_link_flag_directory

Conversation

@jacquesg
Copy link
Copy Markdown
Contributor

@jacquesg jacquesg commented May 20, 2019

Some older MinGW toolchains may not have it defined:

deps/libgit2/src/win32/posix_w32.c: In function 'p_symlink':
deps/libgit2/src/win32/posix_w32.c:409:14: error: 'SYMBOLIC_LINK_FLAG_DIRECTORY' undeclared (first use in this function); did you mean 'SYMLINK_FLAG_RELATIVE'?
   dwFlags |= SYMBOLIC_LINK_FLAG_DIRECTORY;
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
              SYMLINK_FLAG_RELATIVE
deps/libgit2/src/win32/posix_w32.c:409:14: note: each undeclared identifier is reported only once for each function it appears in

@ethomson ethomson merged commit 040db8a into libgit2:master May 20, 2019
@ethomson
Copy link
Copy Markdown
Member

ethomson commented May 20, 2019

Thanks for this.

@pks-t pks-t mentioned this pull request May 20, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacquesg @ethomson @pks-t