Skip to content

Some CI enhancements#4933

Merged
ethomson merged 3 commits into
libgit2:masterfrom
tiennou:ci/enhance
Jan 19, 2019
Merged

Some CI enhancements#4933
ethomson merged 3 commits into
libgit2:masterfrom
tiennou:ci/enhance

Conversation

@tiennou
Copy link
Copy Markdown
Contributor

@tiennou tiennou commented Jan 11, 2019

Since Coverity is down at the moment with no timeframe, isolate it from the nightly run. I think it also makes sense from a concern-separation POV, as it insulates the Azure "hosted" pipelines from flakyness.

This also attempts to enable the few GITTEST_INVASIVE_FS_SIZE (though I'm not sure how Azure will react, or if my run_test invocation is valid 🤞).

@tiennou
ci: move coverity in its own pipeline
3c6d197 
Since Coverity is down for a unspecified timeframe, isolate it from the
"hosted" nightlies.
@tiennou tiennou mentioned this pull request Jan 11, 2019
Merged
@tiennou
Copy link
Copy Markdown
Contributor Author

tiennou commented Jan 14, 2019

/rebuild

@ethomson
Copy link
Copy Markdown
Member

ethomson commented Jan 14, 2019

Hmm, looks like this slows down the CI builds a fair bit (the test phase for one of the amd64 tests went from 6.5 min to about 10 mins). Maybe we should run the invasive tests in the nightlies and skip them in PR validation and CI builds?

@tiennou
Copy link
Copy Markdown
Contributor Author

tiennou commented Jan 15, 2019

I wasn't really expecting those to be in the main run, but it sure makes testing easier. I'll move them to nightly now that I know they're green.

Note that I didn't enable GITTEST_INVASIVE_FS_STRUCTURE, not being sure if I'd wreck something on the builders (I know macOS would not want anything at / without sudo). Should I try to enable it as well ?

@ethomson
Copy link
Copy Markdown
Member

ethomson commented Jan 15, 2019

Note that I didn't enable GITTEST_INVASIVE_FS_STRUCTURE, not being sure if I'd wreck something on the builders (I know macOS would not want anything at / without sudo). Should I try to enable it as well ?

👍 Let's do it!

@ethomson ethomson mentioned this pull request Jan 19, 2019
Merged
@ethomson ethomson merged commit 54ae052 into libgit2:master Jan 19, 2019
@ethomson
Copy link
Copy Markdown
Member

ethomson commented Jan 19, 2019

Thanks @tiennou! I set this up so that the invasive tests only run nightly.

@tiennou tiennou deleted the ci/enhance branch April 5, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tiennou @ethomson