smart protocol: PACK packets are illegal while downloading refs#4694
Merged
Conversation
This was referenced Jun 24, 2018
Member
|
Thanks for this - a minor complaint: we start error message in lower-case, so that library consumers can prepend their own error message. For example, we do: So that users can report: So - rather than bouncing this back for you to fix - I took the liberty of changing your error message. I manually merged this. Thanks for fuzzing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the best fix, but without this fix we can cause a git2 client to spin forever allocating memory by responding with the four characters "PACK" to a smart protocol client:
This bug was found by an oss-fuzz integration I'm working on.