Skip to content

Leak fixes for v0.27.1 #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pks-t merged 3 commits into from
Apr 20, 2018
Merged

Leak fixes for v0.27.1 #4635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
836ec31
local: fix a leaking reference when iterating over a symref
tiennou Apr 18, 2018
8122ef9
worktree: fix calloc of the wrong object type
tiennou Apr 18, 2018
df4937b
remote: repo is optional here
tiennou Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/remote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ static int create_internal(git_remote **out, git_repository *repo, const char *n
goto on_error;

/* only write for non-anonymous remotes */
if (name && (error = write_add_refspec(repo, name, fetch, true)) < 0)
if (repo && name && (error = write_add_refspec(repo, name, fetch, true)) < 0)
goto on_error;

if (repo && (error = lookup_remote_prune_config(remote, config_ro, name)) < 0)
Expand Down
4 changes: 3 additions & 1 deletion src/transports/local.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,10 @@ static int foreach_reference_cb(git_reference *reference, void *payload)
git_revwalk *walk = (git_revwalk *)payload;
int error;

if (git_reference_type(reference) != GIT_REF_OID)
if (git_reference_type(reference) != GIT_REF_OID) {
git_reference_free(reference);
return 0;
}

error = git_revwalk_hide(walk, git_reference_target(reference));
/* The reference is in the local repository, so the target may not
Expand Down
2 changes: 1 addition & 1 deletion src/worktree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ static int open_worktree_dir(git_worktree **out, const char *parent, const char
goto out;
}

if ((wt = git__calloc(1, sizeof(struct git_repository))) == NULL) {
if ((wt = git__calloc(1, sizeof(*wt))) == NULL) {
error = -1;
goto out;
}
Expand Down