git_index_add_frombuffer: only accept files/links#4529
Merged
Conversation
pks-t
approved these changes
Feb 16, 2018
Member
pks-t
left a comment
pks-t
left a comment
There was a problem hiding this comment.
Looks good to me. Only thing that stood out that you were testing all file modes except GIT_FILEMODE_LINK in the new test. Don't know if it's valuable to explicitly test that, as well.
Ensure that the buffer given to `git_index_add_frombuffer` represents a regular blob, an executable blob, or a link. Explicitly reject commit entries (submodules) - it makes little sense to allow users to add a submodule from a string; there's no possible path to success.
ethomson
force-pushed
the
ethomson/index_add_requires_files
branch
from
8c485b8 to
5f774db
Compare
Member
Author
|
It seems only minimally valuable, but it's also very easy, so I went ahead and added a test. Thanks, @pks-t. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the buffer given to
git_index_add_frombufferrepresents a regular blob, an executable blob, or a link. Explicitly reject commit entries (submodules) - it makes little sense to allow users to add a submodule from a string; there's no possible path to success.