Skip to content

odb: export mempack backend#4497

Merged
pks-t merged 1 commit into
libgit2:masterfrom
medranocalvo:export-mempack
Jan 25, 2018
Merged

odb: export mempack backend#4497
pks-t merged 1 commit into
libgit2:masterfrom
medranocalvo:export-mempack

Conversation

@medranocalvo
Copy link
Copy Markdown
Contributor

@medranocalvo medranocalvo commented Jan 22, 2018

Fixes #4492, #4496 .

@medranocalvo
Copy link
Copy Markdown
Contributor Author

medranocalvo commented Jan 22, 2018

The failure is unrelated to the changes:

1:   1) Failure:
1: online::badssl::self_signed [C:\projects\libgit2\tests\online\badssl.c:60]
1:   Function call failed: (git_clone(&g_repo, "https://self-signed.badssl.com/fake.git", "./fake", ((void *)0)))
1:   error -1 (expected -17) - failed to send request: The buffers supplied to a function was too small.
1: 
1: 
1/3 Test #1: libgit2_clar .....................***Failed  241.92 sec

@pks-t pks-t merged commit 71c4306 into libgit2:master Jan 25, 2018
@pks-t
Copy link
Copy Markdown
Member

pks-t commented Jan 25, 2018

Thanks a lot for your fix, this is obviously correct! Will also mark it as backport for v0.25.1.

@pks-t pks-t added the backport label Jan 25, 2018
@pks-t pks-t mentioned this pull request Jan 25, 2018
Closed
@pks-t pks-t mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@medranocalvo @pks-t