stransport: provide error message on trust failures#4444
Merged
Conversation
| @@ -84,6 +84,7 @@ static int stransport_connect(git_stream *stream) | |||
|
|
|||
| if (sec_res == kSecTrustResultDeny || sec_res == kSecTrustResultRecoverableTrustFailure || | |||
| sec_res == kSecTrustResultFatalTrustFailure) | |||
Contributor
There was a problem hiding this comment.
I think you may want braces for this if statement now that it's two expressions?
Contributor
Author
There was a problem hiding this comment.
Yeah right 😆 . I miss my goto fails so much.
Contributor
Author
|
Fixed ! |
Member
|
Thanks a lot @tiennou, this look obviously correct. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4440