libFuzzer: Fix a git_packfile_stream leak#4431
Merged
Merged
Conversation
This change ensures that the git_packfile_stream object in git_indexer_append() does not leak when the stream has errors. Found using libFuzzer.
Contributor
Author
|
PTAL |
pks-t
approved these changes
Dec 6, 2017
Member
pks-t
left a comment
pks-t
left a comment
There was a problem hiding this comment.
Looks good to me, thank you! Just waiting a short amount of time whether anybody else chimes in.
| return; | ||
|
|
||
| if (idx->have_stream) | ||
| git_packfile_stream_free(&idx->stream); |
Member
There was a problem hiding this comment.
Meh, this function doesn't conform to our usual style. 'free' would usually denote the structure itself bein free'd as well, which would have segfaulted here. But it only calls inflateEnd, so this looks good.
Member
|
Thanks for the great test, too! 😻 |
Member
|
Thanks again for your PR! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the git_packfile_stream object in
git_indexer_append() does not leak when the stream has errors.
Found using libFuzzer.