[RFC] Khash refactorings (pt. 2)#4417
Closed
pks-t wants to merge 20 commits into
Closed
Conversation
Breaks idxmap
Member
Author
|
Closing in favor of #4901 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another round of khash fixes. While my first round of fixes only touched our own abstractions (git_oidmap, git_strmap, git_idxmap and git_offmap), this PR revamps the complete khash implementation. I've been too fed up with digging into those awful macros, so I decided to take the bait and decided to refactor that part.
So what I did is to make the khash implementation itself non-generic. Instead of having a macro to create per-type map structs, we now have a single map which has a void pointer only. This relieves us of all those macro magic, but possibliy at the cost of performance. I haven't measured that yet, but will do so if desired.
So this is mostly cosmetic only. I plan to do further refactorings in the future, as I think our map interfaces simply suck right now. They are not intuitive and do not follow our coding guidelines. This here is a first step, but seeing that it may be controverse I wanted to put up a RFC first.