CHANGELOG: add various changes introduced since v0.25#4254
Conversation
pks-t
left a comment
pks-t
left a comment
There was a problem hiding this comment.
Two new API calls could be improved regarding their naming, I guess. This is now our last change to rename them before making them public. Opinions?
| linked worktree is in detached HEAD mode. | ||
|
|
||
| * `git_repository_item_path()` lets you retrieve paths for various repository | ||
| files. |
There was a problem hiding this comment.
Would git_repository_file_path() be a better name?
There was a problem hiding this comment.
I think that I prefer GIT_REPOSITORY_ITEM_* and git_repository_item_path over file... they're both a bit vague, though. But I can't think of anything superior offhand.
I'm happy with what we have, but if you think it's too vague then we can spend some brain cycles on something superior...?
There was a problem hiding this comment.
Let's leave it as is, then.
|
|
||
| * You can enable us calling `fsync` for various objects by setting the | ||
| `GIT_OPT_ENABLE_SYNCHRONIZED_OBJECT_CREATION` option with | ||
| `git_libgit2_opts()`. |
There was a problem hiding this comment.
This option is not only about object creation, but it also modifies how we handle e.g. references. So maybe we should tweak this to GIT_OPT_ENABLE_SYNCHRONIZED_FILE_CREATION?
There was a problem hiding this comment.
Hmm. I worry that FILE_CREATION makes it sound like we'll synchronize everything (including the working directory), which we don't...
GIT_OPT_ENABLE_SYNCHRONIZED_REPO_ACCESS...
GIT_OPT_ENABLE_SYNCHRONIZED_REPOSITORY...
GIT_OPT_ENABLE_FSYNC_OBJECTS_AND_REFS...
GIT_OPT_ENABLE_FSYNC_REPOSITORY...?
I dunno.
There was a problem hiding this comment.
That's true. What about GIT_OPT_ENABLE_FSYNC_GITDIR? Granted, we do not currently synchronize e.g. the config files inside of the gitdir, but I think the term repo is not as unambiguous for non-git-devs as one might think.
There was a problem hiding this comment.
Do you want to send a PR to fix that up or shall I?
There was a problem hiding this comment.
I've got some spare time right now, will create a PR
pks-t
force-pushed
the
pks/changelog-v0.26
branch
from
f7087ed to
a151088
Compare
|
Updated to match new option name |
2 participants
No description provided.