Fix resolving absolute symlinks (on at least Win32)#4169
Closed
csware wants to merge 1 commit into
Closed
Conversation
The symlink destination is always concatenated to the original path. See issue #4168. Signed-off-by: Sven Strickroth2 <[email protected]>
pks-t
added a commit
that referenced
this pull request
Mar 20, 2017
Member
|
I've manually merged this via 3105992. I've changed your commit to use Thanks for this fix! 😄 |
yuyichao
added a commit
to JuliaLang/julia
that referenced
this pull request
Apr 29, 2017
Ref libgit2/libgit2#4169 * Test this on unix * Do not write to user's global gitconfig
yuyichao
added a commit
to JuliaLang/julia
that referenced
this pull request
Apr 29, 2017
Ref libgit2/libgit2#4169 * Test this on unix * Do not write to user's global gitconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symlink destination is always concatenated to the original path.
See issue #4168.
based on the implementation I assume that this is also broken for *nix symlinks.