Fix a few recent warnings#4087
Conversation
| * @see git_treebuilder_write | ||
| * | ||
| * @param id Pointer to store the OID of the newly written tree | ||
| * @param oid Pointer to store the OID of the newly written tree |
There was a problem hiding this comment.
This change conflicts with the one from @ethomson regarding the same issue. Only that he changed the argument's name in the function prototype instead of the docs. Hopefully we will not end up with both patches applied, resulting in the same but reversed issue :P
There was a problem hiding this comment.
Generally, we prefer id in things like commit_id or tree_id. We're sort of mixed about it when we're just talking about an id. There are a significant number of oids when we're not explicit about what kind of id.
Anyway, we might want to clarify that, but this needn't be the place. I'll drop my patches for these two changes.
There was a problem hiding this comment.
Yes, we decided a while back that the style is to use id as the name for object names, and "oid" is just a type. We did go through the API at one point to fix it all up, but it's quite probably they've snuck back in.
|
Thanks, @tiennou ! |
4 participants
No description provided.