Skip to content

Mention field addition in breaking API changes#4065

Merged
ethomson merged 2 commits into
libgit2:masterfrom
simonbyrne:sb/changelog
Jan 6, 2017
Merged

Mention field addition in breaking API changes#4065
ethomson merged 2 commits into
libgit2:masterfrom
simonbyrne:sb/changelog

Conversation

@simonbyrne
Copy link
Copy Markdown
Contributor

proxy_opts fields were added to 2 structs, but not mentioned in the CHANGELOG. Cross ref JuliaLang/julia#19793.

@simonbyrne
Copy link
Copy Markdown
Contributor Author

Also git_merge_options change was in the wrong section.

@simonbyrne
Copy link
Copy Markdown
Contributor Author

simonbyrne commented Jan 3, 2017

The release notes (https://github.com/libgit2/libgit2/releases/tag/v0.25.0) should probably be updated as well, but this can't be done via a PR.

@ethomson
Copy link
Copy Markdown
Member

ethomson commented Jan 6, 2017

Thanks for updating this. I'll also update the release notes on the web page. I'll open a PR to backport this to maint/v0.25.

@ethomson ethomson merged commit 5afd0f9 into libgit2:master Jan 6, 2017
@ethomson ethomson mentioned this pull request Jan 6, 2017
@simonbyrne simonbyrne deleted the sb/changelog branch January 9, 2017 11:29
carlosmn added a commit that referenced this pull request May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants