WinHTTP: set proper error messages when SSL fails#4050
Merged
Conversation
ethomson
force-pushed
the
ethomson/winhttp_errmsgs
branch
from
b0e778a to
8730c65
Compare
Set up a WinHTTP status callback; inspect the WinHTTP status for WINHTTP_CALLBACK_STATUS_SECURE_FAILURE, and convert the status code to a useful message for callers.
ethomson
force-pushed
the
ethomson/winhttp_errmsgs
branch
from
8730c65 to
1910a04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SSL fails for the WinHTTP transport, by default we set the error message to the most unhelpful "user cancelled certificate check", which is set when there is no
giterrset, even when there is no user certificate check configured.Instead, try to capture the SSL failure to provide a more helpful error message by setting a status callback and looking for security failures (
WINHTTP_CALLBACK_STATUS_SECURE_FAILURE), and providing a helpful error message for them.If the security failure is not reported, and there is no user certificate check, update the error message to not suggest that the (nonexistent) user certificate check is at fault.