As a gentle reminder, please try to quote any macro names with backticks, e.g. @return, as we don't want to bother github users by accidentally mentioning them in issues like this.

This change doesn't match what is shown in the official libgit2 documentation, what do you think about applying this change to libgit2 upstream?

As a gentle reminder, please try to quote any macro names with backticks

I will do, sorry about that. I created my GitHub account last night and this is my first contribution. I honestly didn't think about it.

This change doesn't match what is shown in the official libgit2 documentation

The documentation is wrong, as you can see from the linked issue. That's the reason for the fix.

Thanks!

This change doesn't match what is shown in the official libgit2 documentation, what do you think about applying this change to libgit2 upstream?

To clarify: this is a change to the documentation. Our docs are automatically generated from the public headers, so this will update them.

And thanks again @vivaladev ✨ ! Welcome to the libgit2 project! 😀

My goodness, I was so confused. I thought I was in a completely different repository. Sorry for the noise! ;)

Thank you @ethomson

I noticed this "bug" while trying to figure out why something doesn't work as expected with some patch functions. Hopefully I will be able to contribute more as soon as I get my head around it (I will open an issue at least).