Enable https transport for custom TLS streams#3850
Conversation
|
This is something we've gone back and forth on a bit. Whether we should treat HTTPS or SSH any different just because git ships with them. We currently treat them as any other pluggable protocol, but there's been some confusion as it often ends up without HTTPS on the field. The way to fix this should be to remove the special-casing, rather than adding more. If adding this define makes the code work sensibly, it shows that we don't actually need it and should instead let the TLS stream constructors error out instead. |
| | GIT_FEATURE_THREADS | ||
| #endif | ||
| #if defined(GIT_OPENSSL) || defined(GIT_WINHTTP) || defined(GIT_SECURE_TRANSPORT) | ||
| #if defined(GIT_OPENSSL) || defined(GIT_WINHTTP) || defined(GIT_SECURE_TRANSPORT) || defined(GIT_CUSTOM_TLS) |
There was a problem hiding this comment.
This defines are there to show how libgit2 was compiled. Adding this would make it meaningless.
|
Fair enough. Removing this make sense as TLS stream creation would fail if stream constructor is not provided. |
|
Bump. Thoughts on this without any of the ifdefs? |
|
@ethomson Review, plz. |
|
Yep! This looks good to me - thanks! |
5 participants
Unfortunately, custom TLS stream API is useless because
httpstransport become disabled when any of secure connection frameworks aren't used.