Skip to content

Cleanups#3834

Merged
ethomson merged 2 commits into
libgit2:masterfrom
pks-t:pks/cleanups
Jun 21, 2016
Merged

Cleanups#3834
ethomson merged 2 commits into
libgit2:masterfrom
pks-t:pks/cleanups

Conversation

@pks-t
Copy link
Copy Markdown
Member

@pks-t pks-t commented Jun 21, 2016

Just found a small housekeeping-branch lingering when cleaning up branches in my fork of libgit2. As it surprisingly rebased without any conflicts (yay, git!) I'm just putting it up here.

pks-t added 2 commits June 21, 2016 07:58
Avoid declaring old-style functions without any parameters.
Functions not accepting any parameters should be declared with
`void fn(void)`. See ISO C89 $3.5.4.3.
cl_git_sandbox_cleanup();
}

static int dont_call_me_cb(const char *fetch_refspec, void *payload)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL.

@ethomson
Copy link
Copy Markdown
Member

@ethomson ethomson merged commit 37e9278 into libgit2:master Jun 21, 2016
@pks-t pks-t deleted the pks/cleanups branch June 27, 2016 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants