fix: remove dangling pointer to work_output in CLIPTextModel#111
Merged
Conversation
Owner
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLIPTextModel::begin()creates awork_outputtensor using the providedwork_ctxbutCLIPTextModel::end()does not set this value back toNULL, causing the next call toCLIPTextModel::begin()to not allocate a new tensor and use the value from the previous iteration instead, which is now a dangling pointer and thus invalid. This means that attempts to make multiple generation calls (StableDiffusion::txt2img()/StableDiffusion::img2img()) using a singleStableDiffusioninstance will cause memory corruption and results in a segmentation fault.This doesn't affect the example "sd" binary as it creates the instance and only performs a single generation call before exiting, and this bug only occurs if a single instance is used for generation twice.