Level 2 - #3
Closed
abirukov wants to merge 3 commits into
Closed
Conversation
Melevir
reviewed
Feb 17, 2023
| def is_point_in_square( | ||
| point: tuple[int, int], | ||
| left_upper_corner: tuple[int, int], | ||
| right_bottom_corner: tuple[int, int] |
Contributor
There was a problem hiding this comment.
Запятой не хватает в конце.
| def get_transaction_amount(transaction_id: ___, transactions_amounts_map: ___) -> ___: | ||
| def get_transaction_amount( | ||
| transaction_id: int, | ||
| transactions_amounts_map: dict[int, decimal.Decimal] |
Contributor
There was a problem hiding this comment.
transactions_amounts_map по логике не меняется, поэтому тут можно заменить dict на Mapping.
Так же в некоторых аннотациях ниже.
|
|
||
|
|
||
| def get_current_user() -> ___: | ||
| def get_current_user() -> tuple[str, int]: |
Contributor
There was a problem hiding this comment.
tuple[str, int] значит тупл из двух элементов: первай строка, второй инт. А тут не так.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.