Skip to content

Match service type with record name ending #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjester merged 2 commits into from
Feb 9, 2022
Merged

Match service type with record name ending #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cddfde
Match service type with record name ending
bjester Feb 9, 2022
f97653d
Bump version and update changelog
bjester Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,14 @@ See examples directory for more.
Changelog
=========

0.19.16
-------
- Fix issue preventing TXT record updates from `ServiceBrowser`

0.19.15
-------
- Track all requested broadcast interfaces in addition to those successfully attached


0.19.14
-------
- Exclude addresses starting with "169.254" from the list returned by get_all_addresses()
Expand Down
11 changes: 8 additions & 3 deletions zeroconf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@

__author__ = "Paul Scott-Murphy, William McBrine"
__maintainer__ = "Learning Equality <[email protected]>"
__version__ = "0.19.15"
__version__ = "0.19.16"
__license__ = "LGPL"


Expand Down Expand Up @@ -1386,6 +1386,11 @@ def update_record(self, zc, now, record):

Updates information required by browser in the Zeroconf cache."""

# if the record name does not end with the service type we're listening for,
# we'll ignore the update
if not record.name.endswith(self.type):
return

def enqueue_callback(state_change, name):
self._handlers_to_call.append(
lambda zeroconf: self._service_state_changed.fire(
Expand All @@ -1396,7 +1401,7 @@ def enqueue_callback(state_change, name):
)
)

if record.type == _TYPE_PTR and record.name == self.type:
if record.type == _TYPE_PTR:
expired = record.is_expired(now)
service_key = record.alias.lower()
try:
Expand All @@ -1417,7 +1422,7 @@ def enqueue_callback(state_change, name):
if expires < self.next_time:
self.next_time = expires

elif record.type == _TYPE_TXT and record.name == self.type:
elif record.type == _TYPE_TXT:
assert isinstance(record, DNSText)
expired = record.is_expired(now)
if not expired:
Expand Down