Match service type with record name ending#15
Merged
bjester merged 2 commits intoFeb 9, 2022
Conversation
Member
Author
|
So looks like for a PTR record, the name would be the same as the service type, but would be the full instance name for a TXT. I think it's still safe to have the |
Merged
9 tasks
Member
|
I triggered a re-run on the tests to see whether the "this message is too long" was just stochastic. If not, I guess maybe it's because a message that was previously skipped is now being accepted, and can't be processed properly. |
Member
|
Looks as if the tests are still failing on MacOS |
jamalex
approved these changes
Feb 9, 2022
Member
jamalex
left a comment
jamalex
left a comment
There was a problem hiding this comment.
Looks good to me! Though it would be good to get that test passing if we can.
Member
Author
|
Python tests on MacOS have been broken for a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed behavior
In Kolibri, when an instance's information is updated, the instance was properly broadcasting that, but the event wasn't being handled by other instances. I confirmed that instance was properly broadcasting updated information.
Solution
The issue appeared to be that the
ServiceBrowser, which accepts a specific service type to listen for, was performing an equality comparing on the updated record's name with the service type. But the record name should only end with the service type, and shouldn't match exactly, since there can be multiple devices of the same service on a network.