Skip to content

Make is_dataclass robust#1385

Merged
czgdp1807 merged 1 commit intolcompilers:mainfrom
czgdp1807:bindc_struct_arr_1
Dec 27, 2022
Merged

Make is_dataclass robust#1385
czgdp1807 merged 1 commit intolcompilers:mainfrom
czgdp1807:bindc_struct_arr_1

Conversation

@czgdp1807
Copy link
Copy Markdown
Collaborator

@czgdp1807 czgdp1807 commented Dec 27, 2022

The main branch gives the following error,

semantic error: Only dataclass decorated classes and Enum subclasses are supported.
  --> integration_tests/structs_14.py:19:1 - 27:20
   |
19 |    class buffer_struct_clink:
   |    ^^^^^^^^^^^^^^^^^^^^^^^^^^...
...
   |
27 |        buffer7: c64[32]
   | ...^^^^^^^^^^^^^^^^^^^^

This PR fixes the same by making is_dataclass robust with respect to decorators in AST.

@czgdp1807 czgdp1807 marked this pull request as ready for review December 27, 2022 05:48
@czgdp1807 czgdp1807 merged commit 51bbc8e into lcompilers:main Dec 27, 2022
@czgdp1807 czgdp1807 deleted the bindc_struct_arr_1 branch December 27, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czgdp1807 @certik