Skip to content

Add support for imshow()#79

Closed
alexdewar wants to merge 12 commits intolava:masterfrom
alexdewar:imshow
Closed

Add support for imshow()#79
alexdewar wants to merge 12 commits intolava:masterfrom
alexdewar:imshow

Conversation

@alexdewar
Copy link
Copy Markdown
Contributor

This PR adds support for the imshow() function to matplotlibcpp. imshow() displays an image in the current figure and allows for setting extra parameters such as the colormap used.

I've also added a version of the function which takes an OpenCV matrix as an input (in a separate commit), which provides a nicer interface. This requires OpenCV, but I've made this functionality optional: you have to explicitly define WITH_OPENCV if you want it.

@alexdewar
Copy link
Copy Markdown
Contributor Author

PS -- I'm happy to write some example code for this if you'd like.

@lava
Copy link
Copy Markdown
Owner

lava commented Dec 5, 2018

Yes, please. Ideally this would also be called out elsewhere in the README, since it's quite a big change, introducing additional optional dependencies.

@tkphd
Copy link
Copy Markdown
Contributor

tkphd commented May 8, 2019

Hi @lava,

As of 52931d5 this branch is up-to-date with master, and as of c7f73bb it includes a basic example (ignoring OpenCV stuff). I am going to use your library, and it would be great to see @alexdewar's imshow extension merged. You've been busy since this request was originally opened -- is there additional work that should be done before it's satisfactory?

Thanks for building the interface!

lava pushed a commit that referenced this pull request Jul 3, 2019
This addresses comments on #79.
@lava
Copy link
Copy Markdown
Owner

lava commented Jul 3, 2019

Hey, sorry for taking so long to merge such a nice PR. I finally took the time now to squash and merge it.

Thanks for contributing to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants