Skip to content

Commit f113cee

Browse files
committed
refactor: Improve ServerBuilder API
1 parent 0d9d451 commit f113cee

3 files changed

Lines changed: 6 additions & 10 deletions

File tree

‎src/main/java/Main.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ public static void main(String[] args) throws IOException {
66
.port(8080)
77
.build();
88

9-
109
server.run();
1110
}
1211
}

‎src/main/java/Server.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class Server {
2424

2525
private Server(ServerBuilder serverBuilder) {
2626
this.port = serverBuilder.port;
27-
this.defaultSerializer = serverBuilder.defaultSerializer;
27+
this.defaultSerializer = serverBuilder.serializer;
2828

2929
this.state = State.READY;
3030

@@ -183,21 +183,21 @@ public int getPort() {
183183

184184
public static class ServerBuilder {
185185
private int port;
186-
private BodySerializer<?> defaultSerializer;
186+
private BodySerializer<?> serializer;
187187

188188
public ServerBuilder port(int port) {
189189
this.port = port;
190190
return this;
191191
}
192192

193-
public ServerBuilder defaultSerializer(BodySerializer<?> defaultSerializer) {
194-
this.defaultSerializer = defaultSerializer;
193+
public ServerBuilder serializer(BodySerializer<?> serializer) {
194+
this.serializer = serializer;
195195
return this;
196196
}
197197

198198
public Server build() {
199-
if (this.defaultSerializer == null) {
200-
this.defaultSerializer = new GsonDefaultSerializer<>();
199+
if (this.serializer == null) {
200+
this.serializer = new GsonDefaultSerializer<>();
201201
}
202202

203203
return new Server(this);

‎src/test/java/HttpServerRunner.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,5 @@ private void addIntegrationTestRoutes() {
9494
.body(new String(buf))
9595
.build();
9696
});
97-
9897
}
99-
100-
10198
}

0 commit comments

Comments
 (0)