Skip to content

Re-invoke NotFoundHandler if returns an ErrRouteNotFound error#1730

Closed
chenxxpro wants to merge 0 commit intolabstack:masterfrom
bytepowered:master
Closed

Re-invoke NotFoundHandler if returns an ErrRouteNotFound error#1730
chenxxpro wants to merge 0 commit intolabstack:masterfrom
bytepowered:master

Conversation

@chenxxpro
Copy link
Copy Markdown

When middleware returns ErrRouteNotFound, provides a way to re-invoke NotFoundHandler

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1730 (a57035b) into master (194129d) will increase coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
+ Coverage   84.97%   85.79%   +0.81%     
==========================================
  Files          29       29              
  Lines        1983     2020      +37     
==========================================
+ Hits         1685     1733      +48     
+ Misses        189      181       -8     
+ Partials      109      106       -3     
Impacted Files Coverage Δ
context.go 87.25% <100.00%> (+0.65%) ⬆️
echo.go 86.49% <100.00%> (+1.73%) ⬆️
router.go 97.05% <0.00%> (+0.17%) ⬆️
bind.go 90.00% <0.00%> (+5.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194129d...a57035b. Read the comment docs.

@lammel
Copy link
Copy Markdown
Contributor

lammel commented Dec 25, 2020

Thanks for your contribution @yongjiapro

I guess we need some clarification on the purpose or use case behind that change.
The added test does not indicate a real use case (it seems strange to return not found for an existing route).

Could you explain something about your intended use, please?

@stale
Copy link
Copy Markdown

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed within a month if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale for auto-closing label Jun 26, 2021
@chenxxpro chenxxpro closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback needed stale Marked as stale for auto-closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants