Skip to content

fix: missing method invocation in kube_config_test.py#2272

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
kavishdahekar:kavishdahekar-patch-1
Aug 30, 2024
Merged

fix: missing method invocation in kube_config_test.py#2272
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
kavishdahekar:kavishdahekar-patch-1

Conversation

@kavishdahekar
Copy link
Copy Markdown
Contributor

@kavishdahekar kavishdahekar commented Aug 27, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

The test_load_kube_config_from_dict_with_temp_file_path test calls _cleanup_temp_files without invoking it _cleanup_temp_files(). This PR fixes that.

Which issue(s) this PR fixes:

Fixes n/a

Special notes for your reviewer:

n/a

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@kavishdahekar
Update kube_config_test.py
dac8a5c 
fix missing method invocation
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Aug 27, 2024
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Aug 27, 2024 •
edited
Loading

CLA Signed

  • ✅login: kavishdahekar / (dac8a5c)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 27, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2024

Welcome @kavishdahekar!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2024
@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Aug 28, 2024

/assign @yliaog

@kavishdahekar kavishdahekar changed the title fix missing method invocation in kube_config_test.py fix: missing method invocation in kube_config_test.py Aug 29, 2024
@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Aug 30, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavishdahekar, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit d8f35c7 into kubernetes-client:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kavishdahekar @k8s-ci-robot @roycaihw @yliaog