Make job_crud example print the correct job status after job creation by prabha1331 · Pull Request #1418 · kubernetes-client/python

prabha1331 · 2021-04-18T10:48:07Z

create_job function was not printing the current status of the job. Modified the create_job function to call read_namespaced_job_status in order to get the current job status

prabha1331 · 2021-04-18T10:49:55Z

@yliaog Please check this and let me know your comments. Thanks

yliaog · 2021-04-19T17:41:33Z

        namespace="default")
-    print("Job created. status='%s'" % str(api_response.status))
+    # Need to wait for a second for the job status to update
+    sleep(1)


api_response.status is the status immediately after creating 'job'. then controller will run to update the job status as the job is making progress. the time to take for job to run to completion is not determined, it could be short, could be long. the way to get status update is to Watch it.

@yliaog Do i need to write a function to watch the status and print? If yes can you please elaborate it?

https://github.com/kubernetes-client/python/blob/master/examples/pod_namespace_watch.py has an example for 'watch', or, you may periodically poll for status update.

@yliaog Should we just print the status as soon as JOB_NAME get into Initialized Phase in the watch? Or should we wait for the Job to get into Running/Completed phase and then print the status?

It would be great if you can print the watch events until the job succeeded/failed. This can be put into a separate function.

@roycaihw @yliaog I have updated the code to Poll for status update until success/failure. Please check.

yliaog · 2021-05-02T17:37:19Z

+            name=JOB_NAME,
+            namespace="default")
+        if api_response.status.succeeded is not None or api_response.status.failed is not None:
+            job_completed = True


this is hot loop, please add sleep(...)

yliaog · 2021-05-02T17:40:04Z

        body=job,
        namespace="default")
-    print("Job created. status='%s'" % str(api_response.status))
+    print("Job created. status='%s'" % str(get_job_status(api_instance)))


better to keep the previous print line 56 to show the Job is created, then poll for job running status until job is completed

@yliaog sleep for 1 sec is good?

that depends on the how long it takes to complete the job, 1s is probably ok.

@yliaog Please check the code changes now. Thanks.

yliaog · 2021-05-04T16:10:58Z

        body=job,
        namespace="default")
    print("Job created. status='%s'" % str(api_response.status))
+    print("Job status='%s'" % str(get_job_status(api_instance)))


better to move the print to the polling loop below, so that every 1s, the status is printed out

@yliaog Please check the updated code. Thanks

@yliaog @roycaihw Do you have any idea why the travis-ci build is failing?

yliaog · 2021-05-07T16:12:36Z

/lgtm
/approve

yliaog · 2021-05-10T19:02:53Z

/home/travis/build/kubernetes-client/python/kubernetes/../examples/job_crud.py:67:80: E501 line too long (95 > 79 characters)
diff --git a/examples/job_crud.py b/examples/job_crud.py
index 23282bd..eb66789 100644
--- a/examples/job_crud.py
+++ b/examples/job_crud.py
@@ -17,11 +17,10 @@ Creates, updates, and deletes a job object.
"""

from os import path
+from time import sleep

import yaml

-from time import sleep

from kubernetes import client, config

JOB_NAME = "pi"
@@ -59,7 +58,6 @@ def create_job(api_instance, job):
get_job_status(api_instance)

def get_job_status(api_instance):
job_completed = False
while not job_completed:
ERROR: InvocationError for command /home/travis/build/kubernetes-client/python/scripts/update-pycodestyle.sh (exited with code 1)

yliaog · 2021-05-10T19:04:49Z

@steveprabha
the output is from here: https://travis-ci.org/github/kubernetes-client/python/jobs/769884870

prabha1331 · 2021-05-11T08:46:05Z

@steveprabha
the output is from here: https://travis-ci.org/github/kubernetes-client/python/jobs/769884870

@yliaog just ran the command pycodestyle test.py and resolved the below error in new changes. Please check and let me know. Thanks
test.py:68:80: E501 line too long (95 > 79 characters)

roycaihw · 2021-05-11T16:37:14Z


 import yaml

+from time import sleep


the pycodestyle test is picky about the import. Could you make it

from os import path from time import sleep import yaml from kubernetes import client, config

?

@roycaihw I have made the above mentioned change. Please verify now. Thanks

are there any special character on the line after " from time import sleep"?

==============================================
diff --git a/examples/job_crud.py b/examples/job_crud.py
index 2174ef7..ab02761 100644
--- a/examples/job_crud.py
+++ b/examples/job_crud.py
@@ -18,7 +18,7 @@ Creates, updates, and deletes a job object.

from os import path
from time import sleep

import yaml

from kubernetes import client, config

https://travis-ci.org/github/kubernetes-client/python/jobs/770874568 has the diff you can check out

yliaog · 2021-05-13T20:37:15Z

/lgtm
/approve

k8s-ci-robot · 2021-05-13T20:37:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveprabha, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix issue kubernetes-client#1395

7bb0851

create_job function was not printing the current status of the job. Modified the create_job function to call read_namespaced_job_status in order to get the current job status

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2021

k8s-ci-robot requested review from roycaihw and yliaog April 18, 2021 10:48

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2021

yliaog reviewed Apr 19, 2021

View reviewed changes

roycaihw changed the title ~~Fix issue #1395~~ Make job_crud example print the correct job status after job creation Apr 20, 2021

Update job_crud.py

7571b45

prabha1331 requested a review from yliaog May 2, 2021 16:10

yliaog reviewed May 2, 2021

View reviewed changes

Update job_crud.py

370eb79

yliaog reviewed May 4, 2021

View reviewed changes

Update job_crud.py

ecd1fb4

k8s-ci-robot assigned yliaog May 7, 2021

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2021

Update job_crud.py

57ad5d2

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021

roycaihw reviewed May 11, 2021

View reviewed changes

prabha1331 added 2 commits May 12, 2021 11:45

Update job_crud.py

a06bd3a

Update job_crud.py

30477c7

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2021

k8s-ci-robot merged commit a126ab0 into kubernetes-client:master May 13, 2021

Conversation

prabha1331 commented Apr 18, 2021

Uh oh!

prabha1331 commented Apr 18, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prabha1331 Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prabha1331 May 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yliaog commented May 7, 2021

Uh oh!

yliaog commented May 10, 2021

-from time import sleep

Uh oh!

yliaog commented May 10, 2021

Uh oh!

prabha1331 commented May 11, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

from os import path from time import sleep

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yliaog commented May 13, 2021

Uh oh!

k8s-ci-robot commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

prabha1331 Apr 20, 2021 •

edited

Loading

prabha1331 May 8, 2021 •

edited

Loading

from os import path
from time import sleep