Release 17.0 snapshot#1307
Merged
k8s-ci-robot merged 10 commits intokubernetes-client:masterfrom Nov 13, 2020
Merged
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/XXL
Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
Reference: - [kubernetes-client#866](kubernetes-client#866) - [kubernetes-client#959](kubernetes-client#959) Signed-off-by: Nabarun Pal <[email protected]>
Reference: kubernetes-client#974 Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
release-17.0-snapshot
branch
from
6b227da to
a9ad7d7
Compare
Signed-off-by: Nabarun Pal <[email protected]>
roycaihw
reviewed
Nov 13, 2020
|
|
||
| **Important Information:** | ||
|
|
||
| - The Kubernetes Python client versioning scheme has changed. The version numbers used till Kubernetes Python Client v12.y.z lagged behind the actual Kubernetes minor version numbers. From this release, the client is moving a version format `vY.Z.P` where `Y` and `Z` are respectively from the Kubernetes version `v1.Y.Z` and `P` would incremented due to changes on the Python client side itself. Ref: https://github.com/kubernetes-client/python/issues/1244 |
Member
There was a problem hiding this comment.
We should add this to README. Maybe when we do the first v17 alpha release
Member
Author
There was a problem hiding this comment.
Yes. That's what my thoughts were. After we cut the first Alpha, we should put both the things in the Important Imformation block in the README.
roycaihw
reviewed
Nov 13, 2020
| **Important Information:** | ||
|
|
||
| - The Kubernetes Python client versioning scheme has changed. The version numbers used till Kubernetes Python Client v12.y.z lagged behind the actual Kubernetes minor version numbers. From this release, the client is moving a version format `vY.Z.P` where `Y` and `Z` are respectively from the Kubernetes version `v1.Y.Z` and `P` would incremented due to changes on the Python client side itself. Ref: https://github.com/kubernetes-client/python/issues/1244 | ||
| - Python 2 had reached [End of Life](https://www.python.org/doc/sunset-python-2/) on January 1, 2020. The Kubernetes Python Client will drop support for Python 2 from the next release (v18.0.0) and will no longer provide support to older clients as per the [Kubernetes support policy](https://kubernetes.io/docs/setup/release/version-skew-policy/#supported-versions). |
Member
There was a problem hiding this comment.
Do we plan to send notes to the kubernetes-client slack channel and kubernetes-dev mailing list?
Member
Author
There was a problem hiding this comment.
Yes. We should be sending those to the mailing list and Slack channel.
Member
|
Have a question but it doesn't block this PR. /lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
The CHANGELOG also mentions changes in the versioning scheme of the client and about dropping Python 2 support in the next stable release (v18.0.0)
The CHANGELOG in master needs to be updated with changes from the v12 stable release (#1308). This branch already contains changes from #1308. Until then, putting a hold on this PR.
/hold