Fix packaging.#346
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XS
brendandburns
requested review from
drubin and
silasbw
and removed request for
itowlson and
mbohlool
| "files": [ | ||
| "dist/*.ts", | ||
| "dist/*.js", | ||
| "dist/gen/*.ts", |
There was a problem hiding this comment.
https://docs.npmjs.com/files/package.json#files
Do you think we could do
"dist/**/*.js"
"dist/**/*.ts"
Wondering if this would be better then we don't need to remember as the folders change?
There was a problem hiding this comment.
Would that pull in the examples? e.g., dist/exec/
Use the below instead?
"dist/gen/**.js",
"dist/gen/**.ts"
There was a problem hiding this comment.
@silasbw Why would you want to explicitly only include gen?
Is there something different between what I suggested above here?
"dist/**/*.js"
"dist/**/*.ts"
|
Does that also do directory globbing as far as I know it only does current directory. |
|
oops, you're right. I meant: |
brendandburns
force-pushed
the
package
branch
from
2f4d401 to
f134596
Compare
|
Added the glob, please take another look. Thanks! |
|
/lgtm I still think it would be nicer to do "dist//*.js" But don't think it's a blocker and this fixes the actuall issue. |
k8s-ci-robot
added
the
lgtm
4 participants
We changed where we generate the code, but we didn't update package.json to include it in the npm package...
cc @drubin @silasbw