Skip to content

Fixed condition to check expired token for exec auth#237

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
ankitabhopatkar13:patch-1
Apr 26, 2019
Merged

Fixed condition to check expired token for exec auth#237
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
ankitabhopatkar13:patch-1

Conversation

@ankitabhopatkar13
Copy link
Copy Markdown
Contributor

@ankitabhopatkar13 ankitabhopatkar13 commented Apr 25, 2019

Fixes #228

It also fixes the issue where if the token is valid it was regenerating every time.

@ankitabhopatkar13
Fixed condition to check expired token for exec auth
8993516 
Fixes kubernetes-client#228

It also fixes the issue where if the token is valid it was regenerating every time.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 25, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2019
@ankitabhopatkar13
Copy link
Copy Markdown
Contributor Author

ankitabhopatkar13 commented Apr 25, 2019

Signed CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2019
@ankitabhopatkar13
Copy link
Copy Markdown
Contributor Author

ankitabhopatkar13 commented Apr 25, 2019 •
edited
Loading

/assign @brendanburns

@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Apr 26, 2019

/lgtm
/approve

Thanks for the PR

(we should really add a unit test for this)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitabhopatkar13, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5e7c581 into kubernetes-client:master Apr 26, 2019
@snyk-bot snyk-bot mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itowlson itowlson Awaiting requested review from itowlson

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unauthorized status code when calling Kubernetes after token expiration time

3 participants

@ankitabhopatkar13 @k8s-ci-robot @brendandburns