Update client to kubernetes 1.8#84
Conversation
lwander
left a comment
lwander
left a comment
There was a problem hiding this comment.
Looks like some resources changed in name, most importantly V1Pod is now CoreV1Pod (breaks the util package). Is this client still backwards-compatible with prior cluster versions?
|
Looks like the URL path stays the same for CoreV1Pods. When a resource is promoted from a beta track to v1, does the API spec keep the beta resource around? |
|
I will look into this. Probably I need to change the pre-processing script to keep the names backward compatible. That would benefit all clients. Will update this PR and ping you when it is ready. Thanks. |
|
@lwander I fixed the client generator in kubernetes-client/gen#24 and updated the client here using the new code to see if it fixed the problem. Please take another look. |
|
Looks good - shame the extra parameters are required for all API calls |
|
I'm ready to merge when you are |
|
The other PR is merged. Please merge this one. Thanks. |
2 participants
Add update client script and update client to kubernetes 1.8.