Skip to content

Replaced hard-coded string with ApiregistrationV1beta1ServiceReference.class#749

Closed
hpandeycodeit wants to merge 1 commit into
kubernetes-client:masterfrom
hpandeycodeit:master
Closed

Replaced hard-coded string with ApiregistrationV1beta1ServiceReference.class#749
hpandeycodeit wants to merge 1 commit into
kubernetes-client:masterfrom
hpandeycodeit:master

Conversation

@hpandeycodeit

Copy link
Copy Markdown
Contributor

Replaced hard-coded string with ApiregistrationV1beta1ServiceReference.class

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hpandeycodeit
To complete the pull request process, please assign mbohlool
You can assign the PR to them by writing /assign @mbohlool in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2019
@hpandeycodeit

Copy link
Copy Markdown
Contributor Author

I just noticed there are several java classes with the same hard-coded class name. If it's okay I will go ahead and clean them up as a part of this PR.

@yue9944882

Copy link
Copy Markdown
Member

can you show us the difference between the two approaches? btw those code are machine generated, you need to edit on the code-template then re-gen.

@hpandeycodeit

Copy link
Copy Markdown
Contributor Author

No difference actually, just more from the java coding standard point of view. Also, since it's auto-generated this need not be corrected. So feel free to close this PR

@brendandburns

Copy link
Copy Markdown
Contributor

This is generated code (and we're about to switch the generator) if you want to fix this, it should be done in the openapi code generator project https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/Java.

I'm going to close this, since we shouldn't modify generated code in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants