Replaced hard-coded string with ApiregistrationV1beta1ServiceReference.class#749
Replaced hard-coded string with ApiregistrationV1beta1ServiceReference.class#749hpandeycodeit wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hpandeycodeit The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I just noticed there are several java classes with the same hard-coded class name. If it's okay I will go ahead and clean them up as a part of this PR. |
|
can you show us the difference between the two approaches? btw those code are machine generated, you need to edit on the code-template then re-gen. |
|
No difference actually, just more from the java coding standard point of view. Also, since it's auto-generated this need not be corrected. So feel free to close this PR |
|
This is generated code (and we're about to switch the generator) if you want to fix this, it should be done in the openapi code generator project https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/Java. I'm going to close this, since we shouldn't modify generated code in this project. |
Replaced hard-coded string with ApiregistrationV1beta1ServiceReference.class