Skip to content

Initial add of proto-buffer files#67

Merged
mbohlool merged 1 commit into
kubernetes-client:masterfrom
brendandburns:proto
Sep 5, 2017
Merged

Initial add of proto-buffer files#67
mbohlool merged 1 commit into
kubernetes-client:masterfrom
brendandburns:proto

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

@lwander

lwander commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

Some of these seem to follow /src/main/java/k8s/io, and others /src/main/java/io/kubernetes (the rest of the repo follow the later). Should we make them consistent?

@brendandburns

Copy link
Copy Markdown
Contributor Author

@lwander fixed (and fixed the generation script too...)

Please take another look.

@lwander

lwander commented Sep 1, 2017

Copy link
Copy Markdown
Contributor

Thanks! I don't think I can review much beyond that... so LGTM

What's the plan for integrating this with the client library?

@brendandburns

Copy link
Copy Markdown
Contributor Author

@lwander good question! I need this library to start experimenting. If you'd prefer, I can wait to merge until I have the complete story, I'll branch off of this PR and keep exploring.

@lwander

lwander commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

I always like to merge sooner rather than later - feel free to merge whenever you feel ready!

@mbohlool mbohlool merged commit b6a1928 into kubernetes-client:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants