Skip to content

Revert "Release-19: Reset release 19 pom version to 19.0.0-SNAPSHOT"#2845

Merged
k8s-ci-robot merged 1 commit into
release-19from
revert-2828-reset-release-19
Oct 24, 2023
Merged

Revert "Release-19: Reset release 19 pom version to 19.0.0-SNAPSHOT"#2845
k8s-ci-robot merged 1 commit into
release-19from
revert-2828-reset-release-19

Conversation

@yue9944882

Copy link
Copy Markdown
Member

Reverts #2828

@brendandburns looks like 19.0.0 is successfully out, am i missing anything? if that worked, we should revert this PR so the version matches

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2023
@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

I think maybe I made a typo in the github action. We should consider modifying it to prevent such errors.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8274629 into release-19 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants