Skip to content

Regenerate for Kubernetes 1.23#2022

Merged
k8s-ci-robot merged 7 commits into
kubernetes-client:masterfrom
brendandburns:proto
Dec 15, 2021
Merged

Regenerate for Kubernetes 1.23#2022
k8s-ci-robot merged 7 commits into
kubernetes-client:masterfrom
brendandburns:proto

Conversation

@brendandburns

@brendandburns brendandburns commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2021
@k8s-ci-robot

k8s-ci-robot commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2021
@brendandburns

brendandburns commented Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

/hold I need to fix the compile issues.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2021
@brendandburns brendandburns changed the title Regenerate for Kubernetes 1.23 [WIP] Regenerate for Kubernetes 1.23 Dec 11, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2021
@yue9944882

yue9944882 commented Dec 12, 2021

Copy link
Copy Markdown
Member

@brendandburns thanks! i think it missed examples for release 14 last time, i will be adding example-14 and 15 together in a follow up.

@brendandburns brendandburns force-pushed the proto branch 2 times, most recently from 53f550a to 7bb01c9 Compare December 12, 2021 21:55
@brendandburns

brendandburns commented Dec 12, 2021

Copy link
Copy Markdown
Contributor Author

@yue9944882 this is mostly ready. I will wait for you to create the new examples directories and then I will rebase this PR, unless you want me to to it in this pr.

@brendandburns

brendandburns commented Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

@yue9944882 I went ahead and just fixed up the examples myself.

This should be ready to merge.

@brendandburns brendandburns changed the title [WIP] Regenerate for Kubernetes 1.23 Regenerate for Kubernetes 1.23 Dec 14, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@brendandburns

brendandburns commented Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

@yue9944882 I fixed the compile error, this is ready to go.

Thanks!

yue9944882
yue9944882 reviewed Dec 15, 2021
View reviewed changes

@yue9944882 yue9944882 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2021
@yue9944882

yue9944882 commented Dec 15, 2021

Copy link
Copy Markdown
Member

/hold cancel

b/c the compile failure is fixed

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1269a95 into kubernetes-client:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yue9944882 yue9944882 yue9944882 left review comments

Assignees

@yue9944882 yue9944882

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendandburns @k8s-ci-robot @yue9944882 @brendanburns