Skip to content

Return specific api type in patchContent and patchType#1888

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
dddddai:master
Sep 16, 2021
Merged

Return specific api type in patchContent and patchType#1888
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
dddddai:master

Conversation

@dddddai

@dddddai dddddai commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Fix #1887

Attach ApiType to KubectlPatch in patchContent and patchType

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2021
@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2021
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dddddai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 69cc44b into kubernetes-client:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KubectlPatch's methods should not return raw type of KubectlPatch

3 participants