Repository navigation
Fix warnings in Xcode 10.2 - #15
Merged
Merged
Conversation
g-bourachot
approved these changes
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @antoinepalazzolo and @g-bourachot , we use your SDK in a framework we develop, and one of our clients has a zero-warnings policy in 3rd party SDKs. This PR fixes warnings that appear in Xcode 10.2 and should have no risk associated with it. I also verified that building in Xcode 10.1 still works.
This was the warning in all three cases:
'public' modifier is redundant for static method declared in a public extensionThanks!