Add msgpack-jackson3 module for Jackson 3.x support#4
Closed
komamitsu wants to merge 6 commits into
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msgpack-jackson3submodule (jackson-dataformat-msgpack3) that ports the existing Jackson 2.x integration to Jackson 3.x (tools.jacksonnamespace)src/jmh/java) runnable via./sbt "msgpack-jackson3/jmh:run"Key differences from
msgpack-jacksoncom.fasterxml.jackson→tools.jacksonTokenStreamLocationreplacesJsonLocation; byte offset passed ascolumnNrMessagePackWriteContextreplacesSimpleStreamWriteContextMessagePackFactory.snapshot()delegates tocopy();rebuild()implemented viaMessagePackFactoryBuilderMessagePackSerializedString: allappend*,put*,write*methods fully implementedPROPERTY_NAMEinstead ofVALUE_NULLTest plan
./sbt "msgpack-jackson3/test"— 112 tests pass./sbt "msgpack-jackson3/jmh:compile"— JMH benchmarks compile cleanlymsgpack-coreandmsgpack-jacksontests unaffected