Skip to content

Play all music in the music sound category.#2

Merged
koca2000 merged 2 commits into
koca2000:masterfrom
Selim042:master
Oct 11, 2017
Merged

Play all music in the music sound category.#2
koca2000 merged 2 commits into
koca2000:masterfrom
Selim042:master

Conversation

@Selim042

@Selim042 Selim042 commented Oct 6, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@mibby

mibby commented Oct 10, 2017

Copy link
Copy Markdown

@koca2000 Any update on getting this merged?

@koca2000

Copy link
Copy Markdown
Owner

@mibby I want to test it. Today I will have time to look at it.

@koca2000

Copy link
Copy Markdown
Owner

@mibby @Selim042 Sorry, but I will not merge this. Many players have music muted in settings and this api is not only for music players.

But I have to say that it is good idea. I can add possibility for developers to change SoundCategory with default value MASTER. Do you agree?

@Selim042

Copy link
Copy Markdown
Contributor Author

What about an optional SoundCategory parameter when declaring a new SoundPlayer for it to play on?

@koca2000

Copy link
Copy Markdown
Owner

Exactly what I mean! And also changeCategory function.

@koca2000 koca2000 removed the question label Oct 10, 2017
@Selim042

Copy link
Copy Markdown
Contributor Author

Sounds good to me. Would you prefer I would take care of it, or are you going to take care of it?

@koca2000

Copy link
Copy Markdown
Owner

If you want to do it as it was your idea, you can. Otherwise I will do it.

@Selim042

Selim042 commented Oct 10, 2017

Copy link
Copy Markdown
Contributor Author

Done @koca2000.

@koca2000 koca2000 merged commit 63eda75 into koca2000:master Oct 11, 2017
@Selim042

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants