Repository navigation
Use file type instead extension - #6
Merged
kintoandar merged 1 commit intoJun 4, 2021
Merged
Conversation
leventyalcin
force-pushed
the
fix/file-type-instead-extension
branch
from
June 4, 2021 13:37
9fb1aee to
9bf432b
Compare
leventyalcin
changed the title
Owner
|
Thank you, makes sense to me 👍 Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using types are better option than using file extension.
For instance, the hooks are neither
fmt-ing nor validatees.tfvarsfiles currently. However, if types are used, detected by https://github.com/pre-commit/identify andpre-commitruns accordinly. Which means these two file extensions will befmt-ed and verified. 👍