Repository navigation
add ifPresent validator to skip missing vars - #2
Open
iyang-pythnon wants to merge 1 commit into
Open
iyang-pythnon wants to merge 1 commit into
iyang-pythnon wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| return true; | ||
| } | ||
|
|
||
| if ($value === '') { |
There was a problem hiding this comment.
allowedValues doesn't skip null for ifPresent validators
High Severity
The allowedValues() method was not updated to return true when $value === null, unlike notEmpty(), isInteger(), and isBoolean() which all received this treatment. When a variable is absent and validated via ifPresent()->allowedValues(...), in_array(null, $choices, true) returns false, causing a spurious validation exception. This defeats the purpose of ifPresent for the allowedValues check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes validation semantics by allowing missing variables to bypass certain assertions, which could hide configuration mistakes if callers switch from
required()toifPresent(). Otherwise it’s a small, well-tested API addition with default behavior preserved.Overview
Adds
Dotenv::ifPresent()to create aValidatorthat does not fail on missing variables, enabling optional env vars to be type/emptiness/value-validated only when present.Updates
Validatorto accept a$requiredflag (defaulting to current behavior) and adjustsnotEmpty(),isInteger(), andisBoolean()to treatnull(missing) as passing when using the optional mode; expands PHPUnit coverage forifPresentacross allowed-values, emptiness, boolean, and integer validations.Written by Cursor Bugbot for commit f656e8b. This will update automatically on new commits. Configure here.