Repository navigation
add store builder and refactor file loading - #1
Open
tomasturner1 wants to merge 1 commit into
Open
tomasturner1 wants to merge 1 commit into
tomasturner1 wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| $this->repository = $repository; | ||
| $this->filePaths = $filePaths; | ||
| $this->shortCircuit = $shortCircuit; | ||
| $this->store = is_array($store) ? new Store($store, true) : $store; |
There was a problem hiding this comment.
Constructor references non-existent Store class
High Severity
The constructor uses new Store($store, true) when an array is passed, but no Store class exists in the Dotenv namespace and none is imported. The actual class is Dotenv\Store\FileStore. This causes a fatal error at runtime whenever someone passes an array as the third constructor argument — the deprecated-but-documented usage path described in UPGRADING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core env file discovery/reading and changes
Dotenvconstructor semantics (with deprecation), so regressions could affect loading behavior and error handling across consumers.Overview
Refactors env file loading to go through a new
Dotenv\Storeabstraction:Dotenvnow holds aStoreInterfaceand calls$store->read()instead of aggregating file reads itself.Adds
StoreBuilder,FileStore, and file helpers (Store\File\Paths,Store\File\Reader) to construct and read env file contents with optional short-circuit behavior, and updatesDotenv::create()to build a store frompaths/names.Updates
safeLoad()to handle missing/unreadable env files via catchingInvalidPathException, replaces the old file-loading tests with new store-focused tests, and documents that passing an array to theDotenv\Dotenvconstructor is now deprecated in favor ofStoreInterface(removal planned for v5).Written by Cursor Bugbot for commit e29c3e3. This will update automatically on new commits. Configure here.