fix for coverage badge - #92
Merged
Merged
Conversation
Owner
|
@nickmerwin thanks, this is ace service! |
Contributor
Author
|
@peter-murach of course! And thank you for the great work on this gem, we use it on https://coveralls.io 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw that we hadn't received any builds on https://coveralls.io/r/peter-murach/github so I looked into it and noticed a couple things:
WebMock was blocking the API POST to coveralls.io, and while in the past we had recommended adding "coveralls.io" to the allowed domains list, I went ahead and added auto-detection to the gem:
lemurheavy/coveralls-ruby@8f02a49#L1R32
Also, since the suite is running both specs and features, I enabled coveralls for specs only (since it's 95% vs Cucumber's 74%); we're working on support for aggregate test results, but not sure yet if it's possible.
Thanks!