Merge pull request #160 from keepsimpleio/fix/vibesuite-logged-in-crash
fix(vibesuite): prevent logged-in crash when learnedSkills is not an array
The progress-hydration effect iterated accountData.learnedSkills with
for...of, guarded only by ?? [], which catches null/undefined but not
other non-array shapes returned by /api/users/me. A non-iterable value
threw "is not iterable" during render, blanking the whole page for
logged-in users while guests (accountData null) were unaffected. Guard
with Array.isArray so only real arrays are hydrated.
Co-Authored-By: Claude Opus 4.7 <[email protected]>#161
Conversation
The weekly cron run against staging/prod was unwatched; the e2e suite stays available for manual runs via yarn test:e2e:*. Co-Authored-By: Claude Opus 4.7 <[email protected]>
ci: remove scheduled Playwright workflow
…array The progress-hydration effect iterated accountData.learnedSkills with for...of, guarded only by `?? []`, which catches null/undefined but not other non-array shapes returned by /api/users/me. A non-iterable value threw "is not iterable" during render, blanking the whole page for logged-in users while guests (accountData null) were unaffected. Guard with Array.isArray so only real arrays are hydrated. Co-Authored-By: Claude Opus 4.7 <[email protected]>
fix(vibesuite): prevent logged-in crash when learnedSkills is not an array The progress-hydration effect iterated accountData.learnedSkills with for...of, guarded only by `?? []`, which catches null/undefined but not other non-array shapes returned by /api/users/me. A non-iterable value threw "is not iterable" during render, blanking the whole page for logged-in users while guests (accountData null) were unaffected. Guard with Array.isArray so only real arrays are hydrated. Co-Authored-By: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.