feat(test-fixtures): add shared domain-write fixture catalog - #63

jsonapi-java-test-fixtures/src/main/java/io/github/kazemek/jsonapi/testfixtures/domainwrite/DomainWriteScenarios.java (1)

203-221: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract the repeated envelope literals into constants.

The envelope at Lines 207-210 and the expected document at Lines 216-218 repeat the same Links, Meta, and JsonApiObject values. The scenario passes only when both sides stay identical. An edit to one side alone produces a silent expectation change.

Bind the three values once and reuse them.

♻️ Proposed refactor

+  private static final Links ENVELOPE_LINKS = Links.ofLinks(Collections.singletonMap("self", null));
+
+  private static final Meta ENVELOPE_META = Meta.of(Map.of("key", "value"));
+
+  private static final JsonApiObject ENVELOPE_JSONAPI = JsonApiObject.ofVersion("1.1");

Then use them in the scenario:

-              new DocumentEnvelope(
-                  Links.ofLinks(Collections.singletonMap("self", null)),
-                  Meta.of(Map.of("key", "value")),
-                  JsonApiObject.ofVersion("1.1")),
+              new DocumentEnvelope(ENVELOPE_LINKS, ENVELOPE_META, ENVELOPE_JSONAPI),
               DomainWriteOutcome.document(
                   new JsonApiDocument(
                       new DocumentData.SingleResource(
                           articleResource("1", "T", "B", List.of(), null)),
                       null,
-                      Meta.of(Map.of("key", "value")),
-                      JsonApiObject.ofVersion("1.1"),
-                      Links.ofLinks(Collections.singletonMap("self", null)),
+                      ENVELOPE_META,
+                      ENVELOPE_JSONAPI,
+                      ENVELOPE_LINKS,
                       null,
                       Map.of())),

Declare the constants before SCENARIOS so static initialization order is correct.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@jsonapi-java-test-fixtures/src/main/java/io/github/kazemek/jsonapi/testfixtures/domainwrite/DomainWriteScenarios.java`
around lines 203 - 221, In DomainWriteScenarios, extract the shared Links, Meta,
and JsonApiObject values used by the “toDocument with envelope passes links,
meta, and jsonapi” scenario into constants declared before SCENARIOS, then reuse
those constants in both the DocumentEnvelope input and expected JsonApiDocument.

jsonapi-java-jackson3/src/main/java/io/github/kazemek/jsonapi/jackson3/internal/MappingDefinitionResolver.java (1)

265-281: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value

Optional: build the member array once per property.

from calls findAnnotationAnywhere three times, and each call allocates a new four-element array. Resolve the members once in from and pass the array to each lookup. The behavior does not change.

♻️ Proposed refactor

     static RoleAnnotations from(BeanPropertyDefinition propertyDefinition) {
+      AnnotatedMember[] members = {
+        propertyDefinition.getField(),
+        propertyDefinition.getGetter(),
+        propertyDefinition.getSetter(),
+        propertyDefinition.getConstructorParameter()
+      };
       return new RoleAnnotations(
-          findAnnotationAnywhere(propertyDefinition, JsonApiId.class),
-          findAnnotationAnywhere(propertyDefinition, JsonApiAttribute.class),
-          findAnnotationAnywhere(propertyDefinition, JsonApiRelationship.class));
+          findAnnotationAnywhere(members, JsonApiId.class),
+          findAnnotationAnywhere(members, JsonApiAttribute.class),
+          findAnnotationAnywhere(members, JsonApiRelationship.class));
     }
 
     private static <A extends Annotation> `@Nullable` A findAnnotationAnywhere(
-        BeanPropertyDefinition propertyDefinition, Class<A> annotationClass) {
-      for (AnnotatedMember member :
-          new AnnotatedMember[] {
-            propertyDefinition.getField(),
-            propertyDefinition.getGetter(),
-            propertyDefinition.getSetter(),
-            propertyDefinition.getConstructorParameter()
-          }) {
+        AnnotatedMember[] members, Class<A> annotationClass) {
+      for (AnnotatedMember member : members) {
         // Jackson's getAnnotation is not `@Nullable-annotated`; use hasAnnotation as the presence
         // check.
         if (member != null && member.hasAnnotation(annotationClass)) {
           return member.getAnnotation(annotationClass);
         }
       }
       return null;
     }

Run spotlessApply and then spotlessCheck if you apply this change.

As per coding guidelines: "Run Spotless formatting when Spotless-covered files or formatter configuration changes: `spotlessApply` followed by `spotlessCheck`."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@jsonapi-java-jackson3/src/main/java/io/github/kazemek/jsonapi/jackson3/internal/MappingDefinitionResolver.java`
around lines 265 - 281, Update from to construct the four-member AnnotatedMember
array once per property and pass it to each annotation lookup instead of
recreating it in findAnnotationAnywhere. Adjust findAnnotationAnywhere to accept
the precomputed members while preserving its existing lookup order and behavior;
run Spotless formatting and verification afterward.

Source: Coding guidelines

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes