Skip to content

deal with error cases in configurations#1687

Merged
bobbrow merged 1 commit intomasterfrom
bobbrow/activeConfigChange
Mar 14, 2018
Merged

deal with error cases in configurations#1687
bobbrow merged 1 commit intomasterfrom
bobbrow/activeConfigChange

Conversation

@bobbrow
Copy link
Copy Markdown
Member

@bobbrow bobbrow commented Mar 14, 2018

  • handle invalid c_cpp_properties.json file with 0 configurations
  • handle case where configs are removed, and this.CurrentConfiguration is out of range.

Just a code change for this. I started writing a regression test but couldn't figure out why the file watchers aren't working so I am unable to get the test to work as expected.

@bobbrow bobbrow requested review from grdowns and sean-mcmanus March 14, 2018 05:32
@bobbrow bobbrow merged commit f857bc4 into master Mar 14, 2018
@bobbrow bobbrow deleted the bobbrow/activeConfigChange branch March 23, 2018 17:37
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants