Fiber#raise: transfer into transferred fibers instead of resuming - #9734
Open
sampokuokkanen wants to merge 1 commit into
Open
sampokuokkanen wants to merge 1 commit into
sampokuokkanen wants to merge 1 commit into
Conversation
Fiber#raise always resumed the target, so a fiber suspended by transfer became "resumed" by the raiser. When it rescued the exception and transferred back, the raiser was marked as resuming and the transfer failed with "attempt to transfer to a resuming fiber". Follow MRI's fiber_raise: forward to the fiber being resumed if there is one, transfer to a fiber suspended by transfer, and only resume a fiber parked in Fiber.yield. io-event's Select selector hits this when cancelling an io_read with Fiber#raise.
sampokuokkanen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiber#raisealways resumed the target, so a fiber suspended by transfer became "resumed" by the raiser. When it rescued the exception and transferred back, the raiser was marked as resuming and the transfer failed with "attempt to transfer to a resuming fiber".Follow MRI's
fiber_raise: forward to the fiber being resumed if there is one, transfer to a fiber suspended by transfer, and only resume a fiber parked in Fiber.yield.io-event's Select selector hits this when cancelling an io_read with Fiber#raise. One step closer to gettingio-eventworking.