Conversation
A few step toward getting Thread.current in general to behave like CRuby, returning the same Thread for all Fiber instances that it owns. Behind the scenes, each Fiber is still backed by a VirtualThread with an associated ThreadContext and RubyThread, but user code should generally not see those. Additional fixes will follow for internal code that has expectations about the current thread of a fiber. See other attempts to do this and issues related: * My attempt: jruby#5827 * Community attempt: jruby#1225 * An early issue: jruby#1806 Relates to test failures mentioned in jruby#9603 and workarounds from users in jruby#9600.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few step toward getting Thread.current in general to behave like CRuby, returning the same Thread for all Fiber instances that it owns.
Behind the scenes, each Fiber is still backed by a VirtualThread with an associated ThreadContext and RubyThread, but user code should generally not see those.
Additional fixes will follow for internal code that has expectations about the current thread of a fiber.
See other attempts to do this and issues related:
Relates to test failures mentioned in #9603 and workarounds from users in #9600.