Skip to content

Disable AliasMethod direct binding for now #9349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Mar 31, 2026
Merged

Disable AliasMethod direct binding for now #9349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions core/src/main/java/org/jruby/ir/targets/indy/InvokeSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,22 +1334,22 @@ MethodHandle buildAliasHandle(ThreadContext context, CacheEntry entry, IRubyObje
if (method instanceof PartialDelegatingMethod delegate) {
DynamicMethod innerMethod = delegate.getRealMethod();
mh = getHandle(context, self, new CacheEntry(innerMethod, entry.sourceModule, entry.token));
} else if (method instanceof AliasMethod alias) {
DynamicMethod innerMethod = alias.getRealMethod();
String name = alias.getName();

// Use a second site to mimic invocation from AliasMethod
MethodType type = type();
if (!functional) type = type.dropParameterTypes(1, 2);
InvokeSite innerSite = (InvokeSite) SelfInvokeSite.bootstrap(LOOKUP, "callFunctional:" + name, type, literalClosure ? 1 : 0, flags, file, line);
mh = innerSite.getHandle(context, self, new CacheEntry(innerMethod, entry.sourceModule, entry.token));
if (!functional) mh = MethodHandles.dropArguments(mh, 1, IRubyObject.class);

alias.setHandle(mh);

if (Options.INVOKEDYNAMIC_LOG_BINDING.load()) {
LOG.info(name() + "\tbound directly through alias to " + Bootstrap.logMethod(method));
}
// } else if (method instanceof AliasMethod alias) {
// DynamicMethod innerMethod = alias.getRealMethod();
// String name = alias.getName();
//
// // Use a second site to mimic invocation from AliasMethod
// MethodType type = type();
// if (!functional) type = type.dropParameterTypes(1, 2);
// InvokeSite innerSite = (InvokeSite) SelfInvokeSite.bootstrap(LOOKUP, "callFunctional:" + name, type, literalClosure ? 1 : 0, flags, file, line);
// mh = innerSite.getHandle(context, self, new CacheEntry(innerMethod, entry.sourceModule, entry.token));
// if (!functional) mh = MethodHandles.dropArguments(mh, 1, IRubyObject.class);
//
// alias.setHandle(mh);
//
// if (Options.INVOKEDYNAMIC_LOG_BINDING.load()) {
// LOG.info(name() + "\tbound directly through alias to " + Bootstrap.logMethod(method));
// }
}

return mh;
Expand Down